Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error C2084: function '__m128i mm_cvtepu8_epi32(void *)' already has a body #108

Closed
wants to merge 98 commits into from
Closed

Fix error C2084: function '__m128i mm_cvtepu8_epi32(void *)' already has a body #108

wants to merge 98 commits into from

Conversation

cgohlke
Copy link

@cgohlke cgohlke commented Jan 3, 2022

Fixes compile errors when building with Visual Studio 2019:

D:\Build\Pillow-SIMD\Pillow-SIMD-9.0.0.post0\src\libImaging\ImagingSIMD.h(17): error C2084: function '__m128i mm_cvtepu8_epi32(void *)' already has a body
D:\Build\Pillow-SIMD\Pillow-SIMD-9.0.0.post0\src\libImaging\ImagingSIMD.h(17): note: see previous definition of 'mm_cvtepu8_epi32'
D:\Build\Pillow-SIMD\Pillow-SIMD-9.0.0.post0\src\libImaging\ImagingSIMD.h(24): error C2084: function '__m256i mm256_cvtepu8_epi32(void *)' already has a body
D:\Build\Pillow-SIMD\Pillow-SIMD-9.0.0.post0\src\libImaging\ImagingSIMD.h(24): note: see previous definition of 'mm256_cvtepu8_epi32'

homm and others added 30 commits December 21, 2021 01:11
@homm
SIMD. fix list (+6 squashed commits)
d506890 
Squashed commits:
[c45b871] update for Pillow-SIMD 3.4.0
[bedd83f] no alpha compositing in this release
[e8fe730] update results for latest version
add Skia results
[a16ff97] add SIMD changes
[82ffbd6] fix readme (+4 squashed commits)
Squashed commits:
[85677f9] fix error
[f44ebb1] update results for unrolled implementation
[83968c3] fix #4
[cd73c51] update link (+11 squashed commits)
Squashed commits:
[5882178] correct spelling
[a0e5956] Why Pillow-SIMD is even faster
[108e72e] Why Pillow itself is so fast
[e8eeda1] spelling fixes
[e816e9c] spelling
[d2eefef] methodology, why not contributed
[2e55786] installation and conclusion
[9f6415e] more info
[67e55b7] more benchmarks
test files
[471d4c5] remove spaces
[904d89d] add performance tests
[4fe17fe] simple readme

SIMD. clarify Following fork

SIMD. update readme

SIMD. update versions in readme

SIMD. Changes
@homm
SIMD. pypi readme, update setup
cbad29d
@dayton1987 @homm
SIMD. Rewritten the Pillow-SIMD readme
fd1d5b5 
SIMD. Updated according to the review

SIMD. fix markup
@homm
SIMD. replace benchmarks with link to pillow-perf
bcf2f5c 
SIMD. for resizing

SIMD. Update readme

SIMD. fix mark

SIMD. Update Uploadcare logo in readme
@homm
SIMD. Exclude tests from package
7be379e
@homm
SIMD. version
aea2d4c
@homm
SIMD AlphaComposite. sse4 implementation
9eac911
@homm
SIMD AlphaComposite. avx2 implementation
27fb333
@homm
SIMD AlphaComposite. increase precision
3428e00
@homm
SIMD AlphaComposite. speedup sse4 by using _mm_mullo_epi16 instead of…
5c35655 
… _mm_mullo_epi32
@homm
SIMD AlphaComposite. speedup avx2 by using _mm256_mullo_epi16 instead…
32efe45 
… of _mm256_mullo_epi32
@homm
SIMD AlphaComposite. fix bugs
0b07c53
@homm
SIMD AlphaComposite. move declarations to beginning of the blocks
37c31b3
@homm
SIMD AlphaComposite. fast div aproximation
16d9221
@homm
SIMD BoxBlur. sse4 ImagingBoxBlur implementation
a300dcd
@homm
SIMD BoxBlur. add parentheses around var declarations
690b5f9
@homm
SIMD BoxBlur. faster box blur for radius < 1
4be316a
@homm
SIMD Filter. 3x3 implementation
bd41c36
@homm
SIMD Filter. 5x5 implementation
fb28b8f
@homm
SIMD Filter. fast 3x3 filter
d8288d2
@homm
SIMD Filter. a bit faster 5x5 filter
37f4c77
@homm
SIMD Filter. improve locality in 5x5 filter
35c8ede
@homm
SIMD Filter. rearrange 3x3 filter to match 5x5
9b1c129
@homm
SIMD Filter. use macros
19546e8
@homm
SIMD Filter. use macros in 3x3
5e0c0e7
@homm
SIMD Filter. 3x3 SSE4 singleband
c7d2b4a
@homm
SIMD Filter. faster 3x3 singleband SSE4
8dc2ecb
@homm
SIMD Filter. reuse loaded values
5ea3518
@homm
SIMD Filter. 3x3 SSE4 singleband: 2 lines
1304d56
@homm
SIMD Filter. First AVX try
a9f0f1f
homm and others added 25 commits December 21, 2021 01:11
@homm
SIMD. sse only when needed
bb47098
@homm
SIMD. version
bb4f8d2
@homm
SIMD ColorLUT. First try
1cdb569
@homm
SIMD ColorLUT. remove SHIFT_ROUNDING
80baf34
@homm
SIMD ColorLUT. improve performance by preliminary index calculation
1cb2796
@homm
SIMD ColorLUT. table_channels==4 case, minor optimizations
a303c26
@homm
SIMD ColorLUT. remove unused utility
0550a47
@homm
SIMD ColorLUT. remove left_mask and right_mask
d3d01d6
@homm
SIMD ColorLUT. AVX2 implementation (near the same speed)
8a8eead
@homm
SIMD ColorLUT. Fast AVX2 implementation with very wired slowdown
eaaec55
@homm
SIMD ColorLUT. finally fix alpha copy
5b9b748
@homm
SIMD. version
3ce15c0
@homm
SIMD ColorLUT. 16bit arithmetic. Access violation fixed
4c01b1a
@homm
SIMD. MSVC compiler
1907110
@homm
SIMD. update changes link
c8ae3fc
@homm
SIMD. version
70ebbc6
@Monirzadeh @homm
#84 add install prerequisites for avoid confutation
c14937c
@lsb @homm
Markdown typo
febb260 
Remove extra parenthesis. Now the link can be parsed as a link
@rsedykh @homm
New Uploadcare logo and date correction
ab6a042
@homm
SIMD Filter. Correct offset for 3x3f_u8
79bf7e6
@homm
SIMD. resolve imports
d752609
@homm
SIMD. version
b36d71c
Update setup.py
9d9af9d
@homm
Merge pull request #107 from lill74/patch-1
92c69c5 
Fix UnicodeDecodeError while installing
@cgohlke
Fix error C2084: function '__m128i mm_cvtepu8_epi32(void *)' already …
f049445 
…has a body
@homm homm mentioned this pull request Jan 4, 2022
Merged
@homm
Copy link
Collaborator

homm commented Jan 4, 2022

Thanks! I've included your fix in #109. With your changes there is a real chance to make standard Pillow tests all green.

Since Pillow-SIMD is a sliding fork, I have to force-push simd/master brunch each time new Pillow versions are released, and all previous PR becomes a mess. So I'm closing this PR.

@homm homm closed this Jan 4, 2022
@homm
Copy link
Collaborator

homm commented Jan 4, 2022

Pillow-SIMD 9.0.0.post1 is released. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cgohlke @homm @dayton1987 @Monirzadeh @lsb @rsedykh