Add GCR-URL environment variable #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Teddy-Schmitz would you mind re-basing this to fix conflicts? |
Teddy-Schmitz
force-pushed
the
gcr-url-env
branch
from
5f311c3
to
5954a9b
Compare
|
Apologies for the delay, I missed the notification email. I have rebased the PR. |
|
Thanks for this @Teddy-Schmitz. My apologies for not merging sooner, I lost track of it which was totally on me. Thanks again! |
|
No worries, thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This adds GCR-URL as an env var so I can add it as a config option for minikube addon setup.
kubernetes/minikube#1253
Let me know if you need anything changed.