Fix #586: require newer excon, use valid parameter keys interface #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added a commit
to bastelfreak/beaker-docker
that referenced
this pull request
Jul 8, 2024
2.2 and older allowed latest excon releases. excon v0.111.0 introduced a frozen string that was incompatible with docker-api 2.2 and older. This was fixed in upserve/docker-api#588. Bumping our dependency to docker-api 2.3 or newer ensures that we don't pull in broken versions by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noted in #586, newer versions of Excon will freeze the valid request keys array. At require time, this will raise an error.
Solution
In version v0.63/v0.64, there was introduced a method on the base middleware that we can extend to satisfy the requirement necessary for the hijack middleware.
We can bump the minimum required
exconversion, and make use of that method, no longer modifying the constant.