-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bitfield command #1159
Conversation
resolves #1150
I tried to model the code after the python implementation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great. There are just some minor convention issues.
(also addresses pr comments)
One thing that can be addressed is being able to infer the length of the result |
opt to pass private properties / methods from pipeline directly into the constructor for the bitfield command. no need to create two separate classes for command and pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome. Thanks.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@upstash/redis](https://togithub.com/upstash/upstash-redis) | [`^1.31.6` -> `^1.32.0`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.31.6/1.32.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@upstash%2fredis/1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@upstash%2fredis/1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@upstash%2fredis/1.31.6/1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@upstash%2fredis/1.31.6/1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.32.0`](https://togithub.com/upstash/redis-js/releases/tag/v1.32.0) [Compare Source](https://togithub.com/upstash/upstash-redis/compare/v1.31.6...v1.32.0) #### What's Changed - DX-1023: Add regex for base url by [@​CahidArda](https://togithub.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1157](https://togithub.com/upstash/redis-js/pull/1157) - feat: add bitfield command by [@​lewxdev](https://togithub.com/lewxdev) in [https://github.com/upstash/redis-js/pull/1159](https://togithub.com/upstash/redis-js/pull/1159) - Resolve Auto Pipeline Arrappend Issue by [@​CahidArda](https://togithub.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1165](https://togithub.com/upstash/redis-js/pull/1165) #### New Contributors - [@​lewxdev](https://togithub.com/lewxdev) made their first contribution in [https://github.com/upstash/redis-js/pull/1159](https://togithub.com/upstash/redis-js/pull/1159) **Full Changelog**: upstash/redis-js@v1.31.6...v1.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
resolves #1150