-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented CI Workflow for visual regression testing using Argos and Playwright. #100
Conversation
@devilkiller-ag - I think we might be missing something here. My understanding is that there is github workflow created for this also. |
Hi @hexsecs, Yeah I noticed that we missed connecting this repo with Argos (https://argos-ci.com/docs/github). I think this has to be done by project owner. |
@devilkiller-ag to get this working we need a workflow added to the repository also. See the example here... |
Okay Sure I will check it out |
@hexsecs I have added the workflow now. Kindly check it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We finally merged the docusaurus code into the main branch recently. Currently your actions are set up to act on main. This is fine and actually what we want, however the pull request is against the uptane_docusaurus
branch. Can you fix to reflect the main
branch? If it is easier you can cancel the pull and resubmit against main
.
I think you can change the branch from directly from github, there is
option to change branch at the top of PR, it will then point to the `main`
branch then you might not need to create a new PR and just might need to
change branch in actions.
…On Mon, 30 Oct 2023, 20:18 Philip Lapczynski, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We finally merged the docusaurus code into the main branch recently.
Currently your actions are set up to act on main. This is fine and actually
what we want, however the pull request is against the uptane_docusaurus
branch. Can you fix to reflect the main branch? If it is easier you can
cancel the pull and resubmit against main.
—
Reply to this email directly, view it on GitHub
<#100 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APLHP3QG2ZU6HOLJ3VWIKXDYB643FAVCNFSM6AAAAAA6P2IFNWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBUGM2DINJWGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to change the merge into branch myself. Looks good thanks!
Thanks @hexsecs 😊 |
Summary of Changes
Implemented CI Workflow for visual regression testing using Argos and Playwright.
Related Issue
Closes #99
Checklist
Reviewer(s)
@hexsecs