-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #93 resolved #94
Conversation
@@ -26,6 +26,7 @@ export default function Community() { | |||
{/* <LinkCard link="#" title="Slack" light="img/community_links/slack.svg" dark="img/community_links/slack.svg" /> */} | |||
<LinkCard link="https://github.com/uptane" title="GitHub" light="img/community_links/github_light.svg" dark="img/community_links/github_dark.svg" /> | |||
<LinkCard link="https://discord.gg/uWyT6gDCqx" title="Discord" light="img/community_links/discord.svg" dark="img/community_links/discord.svg" /> | |||
<LinkCard link="https://www.linkedin.com/company/uptane/" title="Linkedin" light="img/community_links/Linkedin_logo.svg" dark="img/community_links/Linkedin_logo.svg" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lower case the first letter of Linkedin_logo.svg
it should be linkedin_logo.svg
same as stored in img/community_links/linkedin_logo.svg
folder as if we ignore this it will drop an error during the build process, as it is case sensitive
I have changed it to lowercase please check |
Hi @mit-anuj can you please once share the screenshots of how it looks on both dark and light mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I have resolved this issue , if you want me to make any alterations then please let me know I'll be happy to do that
Fixes #93