Update distinfo.py #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to 2 specification sources: exhibit A: https://packaging.python.org/en/latest/specifications/recording-installed-packages/#:~:text=encoded%20with%20the%20urlsafe%2Dbase64%2Dnopad%20encoding%20(base64.urlsafe_b64encode(digest)%20with%20trailing%20%3D%20removed exhibit B: https://peps.python.org/pep-0427/#:~:text=specifically%2C%20md5%20and%20sha1%20are%20not%20permitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Thank you for your documentation website, it was super informative!! 🚀
As I was experimenting with the code, I noticed based on my understandings that:
in RECORD, the order of the CSV is
filename, hash, size; while in the current code it seems to me the last two are currently inverted.Ref: https://packaging.python.org/en/latest/specifications/recording-installed-packages/#:~:text=Each%20record%20is%20composed%20of%20three%20elements%3A%20the%20file%E2%80%99s%20path%2C%20the%20hash%20of%20the%20contents%2C%20and%20its%20size
in RECORD, encoding MD5 is not permitted
Ref: https://peps.python.org/pep-0427/#:~:text=specifically%2C%20md5%20and%20sha1%20are%20not%20permitted
in record, hashing is to be destripped of trailing
=Ref: https://packaging.python.org/en/latest/specifications/recording-installed-packages/#:~:text=encoded%20with%20the%20urlsafe%2Dbase64%2Dnopad%20encoding%20(base64.urlsafe_b64encode(digest)%20with%20trailing%20%3D%20removed
This PR aligns with the reference specifications linked above.
wdyt?
Hope this helps!