separate loggers for each module and exception stack traces in debug …

…log level

py_air_control_exporter/fetchers/http_philips.py

@@ -1,7 +1,10 @@
+import logging
+
 from pyairctrl import http_client
 
 from py_air_control_exporter import fetchers_api
-from py_air_control_exporter.logging import LOG
+
+LOG = logging.getLogger(__name__)
 
 _FAN_SPEED_TO_INT = {"s": 0, "1": 1, "2": 2, "3": 3, "t": 4}
 
@@ -26,10 +29,9 @@ def get_reading(
         )
     except Exception as ex:
         LOG.error(
-            "Could not read values from air control device %s. Error: %s",
-            host,
-            ex,
+            "Could not read values from air control device %s. Error: %s", host, ex
         )
+        LOG.debug("Exception stack trace:", exc_info=True)
         return None
 
 

py_air_control_exporter/main.py

@@ -8,7 +8,8 @@
 
 from py_air_control_exporter import app, fetchers_api, metrics
 from py_air_control_exporter.fetchers import fetcher_registry
-from py_air_control_exporter.logging import LOG
+
+LOG = logging.getLogger(__name__)
 
 
 @click.command()

py_air_control_exporter/metrics.py

@@ -1,12 +1,14 @@
 import itertools
+import logging
 from collections.abc import Iterable
 from dataclasses import dataclass
 
 import prometheus_client.core
 from prometheus_client import Metric, registry
 
 from py_air_control_exporter import fetchers_api
-from py_air_control_exporter.logging import LOG
+
+LOG = logging.getLogger(__name__)
 
 
 @dataclass(frozen=True)
@@ -34,6 +36,7 @@ def collect(self):
                     name,
                     ex,
                 )
+                LOG.debug("Exception stack trace:", exc_info=True)
                 targets_with_errors.add(name)
                 continue
 

pyproject.toml

@@ -50,6 +50,7 @@ lint.ignore = [
     "S101", # Use of `assert` detected
     "PT005", # fixture with leading `_` returns a value
     "PLR2004", # magic value in comparison
+    "TRY400", # use logging.exception
 ]
 
 [tool.hatch.build.targets.wheel]

test/fetchers/test_http_philips.py

@@ -9,6 +9,7 @@
 
 def test_metrics_pyairctrl_failure(mock_http_client, caplog):
     """Error logs explain that there was a failure getting the status from pyairctrl"""
+    caplog.set_level(logging.ERROR)
     mock_http_client["get_status"].side_effect = Exception("Some foobar error")
     assert http_philips.get_reading(host="1.2.3.4") is None
     assert "Could not read values from air control device" in caplog.text