-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies #155
Update Dependencies #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lodash -> lodash-es
Can I get a tldr on this? Sounds like a different thing. (Though I get that lodash is just utils, so this is probably fine.)
I have a Ledger so can test this. Was already on my todo list because of #140. (:
The azimuth-js check.js file takes up a massive amount of space, so probably worth debugging that.
Interesting! It's pulling in all the other contract-specific libs, but I'd hope that gets deduplicated or something?
it doesn't have a chance to get deduplicated because we're just pulling in the |
puts a dollar in the js-ecosystem-headache jar Merge at will! |
@Fang- let me know if this branch works with ledger? just in case, can you also |
I always burn It was initially failing silently, but after updating my Ledger firmware it behaves normally. So, all good! |
I did now! Can authenticate just fine. |
this also happens to bring our audit results back down to 0 vulnerabilities 🎉
I updated react-scripts to 3.0 following the migration guide
I removed babel-polyfill, intending to replace it with
regenerator-runtime/runtime
, according to the migration guide but found that I didn't get an error when loading the ledger page (afaik, the error would have been thrown immediately because of the implicit global dependency on the regenerator-runtime features).I'm going to fully test the ledger flow on Monday using the office ledger, unless you happen to have one, @Fang-.
I can't tell if this is related to this PR or not, but my hotreloading also broke in firefox, and this seems like the relevant issue.
I also added an
analyze
script that shows bundle sizes. The azimuth-js check.js file takes up a massive amount of space, so probably worth debugging that. Likewise for urbit-key-generation.