Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example to readme #3

Merged
merged 4 commits into from
Jul 14, 2024
Merged

add example to readme #3

merged 4 commits into from
Jul 14, 2024

Conversation

6543
Copy link
Contributor

@6543 6543 commented Jul 13, 2024

close #2

@6543 6543 requested a review from a team as a code owner July 13, 2024 19:46
Juneezee
Juneezee requested changes Jul 14, 2024
View reviewed changes
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bartekpacia
bartekpacia approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for contributing! ❤️

6543 and others added 2 commits July 14, 2024 12:16
@6543 @Juneezee
Update README.md
944ca25 
Co-authored-by: Eng Zer Jun <engzerjun@gmail.com>
@6543
add suggestion
71d54df
@6543
Copy link
Contributor Author

6543 commented Jul 14, 2024

@Juneezee yes that shows it even better as you can just copy and exec your example.

I changed it acordingly.

PS: is this pull squash-merged? else I can squash the commits myselfe as I did not do the best job in naming the single commits ...

Juneezee
Juneezee approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Juneezee Juneezee merged commit 1da0091 into urfave:main Jul 14, 2024
9 checks passed
@6543 6543 deleted the add-example-to-readme branch July 14, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia approved these changes

@Juneezee Juneezee Juneezee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use in a simple example in readme.md
3 participants
@6543 @Juneezee @bartekpacia