Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust code style #1862

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Adjust code style #1862

merged 2 commits into from
Jan 28, 2024

Conversation

yassinebenaid
Copy link
Member

What type of PR is this?

  • cleanup

What this PR does / why we need it:

  • Cleans up some of the type redundancy
  • change the name of a variable as recommended by staticcheck :
error var bothEnvFlagsAreSetError should have name of the form errFoo (ST1012)go-staticcheck

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

appreciate your greate work.

Testing

Its just a code style issue. you can run staticcheck and go test ./... .

Release Notes

clean up type redundancy and fix code style

@yassinebenaid yassinebenaid requested a review from a team as a code owner January 27, 2024 17:20
@dearchap dearchap merged commit 00e6067 into urfave:main Jan 28, 2024
11 of 12 checks passed
@yassinebenaid yassinebenaid deleted the adjust-code-style branch February 2, 2024 18:32
@yassinebenaid yassinebenaid restored the adjust-code-style branch February 2, 2024 18:33
@yassinebenaid yassinebenaid deleted the adjust-code-style branch February 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassinebenaid @dearchap