This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
Added IE8 support to script loading #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urish
added a commit
that referenced
this pull request
Jan 12, 2016
Added IE8 support to script loading
|
Looks good, thanks! |
|
Thank you for the incredibly fast response!! Please let me know when you are able to create a release for this change. |
|
Sure thing! |
|
Released as 0.4.1 |
|
Thanks, @urish!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you aren't supporting IE8, but this addition adds support as well as fixes inconsistent behavior in IE9 and 10. In IE10 we noticed that on the first page load this script would fail (callback wouldn't execute) but every page load thereafter worked fine. This change seems to make it work consistently, although I can't really explain why :) It would be really helpful for us if you could include this patch.
Thanks!
Ben