Calendar pipe: wrap setTimeout with outsideAngularApp #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make initTimer to be not static anymore
- pass NgZone and ChangeDetectorRef as parameters to InitTimer method
urish
requested changes
Mar 18, 2017
src/calendar.pipe.ts
Outdated
| CalendarPipe.removeTimer(); | ||
| CalendarPipe.initTimer(ngZone, cdRef); | ||
| ngZone.run(() => cdRef.markForCheck()); | ||
| }, timeToUpdate); |
There was a problem hiding this comment.
We don't really need to run the markForCheck() here - we emit an event on the midnight emitter, and the constructor subscribes and runs the change detector. Since there can be several change detector refs, it makes sense to keep this call inside the constructor.
Also, I think we can remove the runOutsideAngular() from the constructor itself - it seems to be unnecessary left over from times when the timer was created directly inside the constructor.
- remove change detection from InitTimer method
|
Done :) |
|
Sorry, one more fix. Return a timer from runOutsideAngular method to assign it to the CalendarPipe.timer |
|
thanks, looks good! |
|
released as 1.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amCalendar causes protractor to timeout on waiting async Angular #132