Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moment import reworked from wildcard to default #274

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

Delagen
Copy link
Collaborator

@Delagen Delagen commented Dec 20, 2021

Seem also resolve #245

@Delagen
Copy link
Collaborator Author

Delagen commented Dec 20, 2021

@urish Please check it

@urish
Copy link
Owner

urish commented Dec 20, 2021

Thanks Sergey, would you like if I added you as a maintainer for the package? (access to the repo, npm)

As I mentioned in #272 I don't have the bandwidth to maintain it and keep it up to date

@Delagen
Copy link
Collaborator Author

Delagen commented Dec 20, 2021

@urish Seem I don't know how to publish to NPM. If you describe it process, I can take a part)
If you publish this package in manual mode I know how it )

@urish
Copy link
Owner

urish commented Dec 20, 2021

I do publish it in manual mode, though for other packages I use np to automated publishing.

What's your NPM user name?

@Delagen
Copy link
Collaborator Author

Delagen commented Dec 21, 2021

The same, delagen. How changelog is generated?

@Delagen
Copy link
Collaborator Author

Delagen commented Dec 22, 2021

@urish Any news? This is a blocker for me now.

@urish
Copy link
Owner

urish commented Dec 22, 2021

How changelog is generated

Manually.

Do you have the bandwidth to maintain this package moving forward?

@Delagen
Copy link
Collaborator Author

Delagen commented Dec 22, 2021

How changelog is generated

Manually.

Do you have the bandwidth to maintain this package moving forward?

I can take some part time to maintain, but not sure on permanent basis. Also work full time )

@urish
Copy link
Owner

urish commented Dec 22, 2021

Yes, I understand. Well, that's probably better than the current situation. I've invited you to github / npm, welcome on board!

@Delagen Delagen merged commit 41083d6 into urish:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

momentConstructor$a is not a function
2 participants