fix(core): Set default hasNext for subscription results #3015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not all subscription transports have a built-in way of deduplicating subscriptions, since this may not be desireable. However, the presence of this in some transports has previously masked this issue.
The
dedupExchange
can prevent multiple identical operations. However, it backs off when a result comes in that hashasNext === false
set.The issue here is that
subscriptionExchange
s need to sethasNext
totrue
by default for subscription operations to ensure that no duplicate subscriptions are triggeredSet of changes
hasNext
field totrue
for subscriptions inmakeResult