Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Set default hasNext for subscription results #3015

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 7, 2023

Summary

Not all subscription transports have a built-in way of deduplicating subscriptions, since this may not be desireable. However, the presence of this in some transports has previously masked this issue.

The dedupExchange can prevent multiple identical operations. However, it backs off when a result comes in that has hasNext === false set.

The issue here is that subscriptionExchanges need to set hasNext to true by default for subscription operations to ensure that no duplicate subscriptions are triggered

Set of changes

  • Set default hasNext field to true for subscriptions in makeResult

@kitten kitten merged commit 208242b into main Mar 7, 2023
@kitten kitten deleted the fix/subscription-hasnext branch March 7, 2023 14:20
This was referenced Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants