fix(core): Fix legacy GCG generated Variables types #3029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3026
Summary
Fix generated empty
Variables
type as passed to generics, that outputs a type of{ [var: string]: never; }
.A legacy/unsupported version of
typescript-urql
, which wrapsurql
's React hooks, generatesempty variables types as the following code snippet, which is not detected:
NOTE: We cannot guarantee that this actually fixes
@graphql-codegen/typescript-urql
, which will going forward be unsupported. Generally, we choose not to create test harnesses for outside type generators like these, until we'd have our own type/code generator.We cannot guarantee that types of hook/wrapper generators don't break, and instead recommend and support type/code generators that output
TypedDocumentNode
s, such as:@graphql-codegen/typed-document-node
@graphql-codegen/client-preset
Set of changes
{ [prop: string]: never }
check to variables types