Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major(core): remove default exchanges #3033

Merged
merged 12 commits into from
Mar 16, 2023
Merged

major(core): remove default exchanges #3033

merged 12 commits into from
Mar 16, 2023

Conversation

JoviDeCroock
Copy link
Collaborator

Summary

This removes our notion of defaultExchanges and replaces it with the notion of having to add them all separately. This improves the tree-shakeability of urql and introduces people earlier to our concept of exchanges, highlighting that we aim to be an extensible client.

Set of changes

  • remove defaultExchanges
  • make exchanges mandatory in TS

@kitten kitten added the major 🚚 Changes queued for a new major release, which will include breaking changes label Mar 13, 2023
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 10:48 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 17:49 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 17:51 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 17:53 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 17:58 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 18:04 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 13, 2023 18:07 Failure
@github-actions github-actions bot had a problem deploying to staging-3033 March 14, 2023 07:54 Failure
@JoviDeCroock JoviDeCroock force-pushed the remove-default-exchanges branch 2 times, most recently from 4288937 to df21498 Compare March 15, 2023 18:58
@kitten kitten mentioned this pull request Mar 16, 2023
Merged
kitten
kitten approved these changes Mar 16, 2023
View reviewed changes
packages/core/src/client.ts Show resolved Hide resolved
@kitten kitten merged commit 40911d2 into main Mar 16, 2023
@kitten kitten deleted the remove-default-exchanges branch March 16, 2023 14:08
This was referenced Mar 16, 2023
Closed
Open
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitten kitten kitten approved these changes

Assignees
No one assigned
Labels
major 🚚 Changes queued for a new major release, which will include breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @kitten