Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/graphcache): Add missing hasNext/stale flags to cached results #3059

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 16, 2023

Summary

Ensures that the ssrExchange and Graphcache's cacheExchange don't accidentally remove hasNext (or stale) flags.

Set of changes

  • Add hasNext passthrough to Graphcache
  • Add hasNext passthrough to ssrExchange

@kitten kitten merged commit a6d7986 into main Mar 16, 2023
@kitten kitten deleted the fix/missing-hasnext branch March 16, 2023 00:27
@github-actions github-actions bot mentioned this pull request Mar 16, 2023
@kitten
Copy link
Member Author

kitten commented Mar 16, 2023

cc @JoviDeCroock: Pretty trivial, so I went ahead and merged it.
On a side note, I was trying to actually make hasNext and stale required fields. We can still do that, but it'd mean updating like 50–100 lines of failing tests. Not a big deal, but we may want to check whether we really want to do this.
I think it's potentially worth it though.

@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant