fix(core): Handle fetch rejections and pass to makeErrorResult #3131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3128
Summary
We had a missing catch case, where
!response
wasn't handled, which can happen iffetch
rejects immediately rather than delivering a failed response. This would happen in particular due to offline network errors or broken connection attempts.This is a regression introduced in the fetch refactor, and was introduced because we don't have two catch handlers anymore, hence
response!
was an invalid non-undefined assertion.Set of changes
!response
case