Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix preferGetMethod client option #3403

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

Burbenog
Copy link
Contributor

@Burbenog Burbenog commented Oct 16, 2023

Urql client was ignoring 'force' and 'within-url-limit' options for preferGetMethod by simply casting it to boolean.

Now preferGetMethod works as expected

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: cc097e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya 👋 Nice catch! Not sure how we missed this.
On a side-note, please don't forget to read Contributing guides before opening PRs. Just leaving a note since most other repos will have similar ones. In our case it contains some notes on changesets for changelog entries.
Either way, I simply pushed one quickly here ✌️

@kitten kitten changed the title Fix preferGetMethod client option fix(core): Fix preferGetMethod client option Oct 19, 2023
@kitten kitten merged commit 812385d into urql-graphql:main Oct 19, 2023
13 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants