chore(core): try to parse a text/plain content-type response as json #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9410b43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
changed the title
JoviDeCroock
commented
Nov 13, 2023
JoviDeCroock
commented
Nov 13, 2023
JoviDeCroock
commented
Nov 13, 2023
| const text = await response.text(); | ||
| if (text.startsWith('{')) { | ||
| try { | ||
| results = JSON.parse(text); |
There was a problem hiding this comment.
My generator foo is lacking here, does this count, because yield JSON.parse() seems invalid
JoviDeCroock
force-pushed
the
account-for-absent-content-type
branch
from
21d3735
to
b3cfd44
Compare
kitten
reviewed
Nov 14, 2023
| throw new Error(await response.text()); | ||
| const text = await response.text(); | ||
| try { | ||
| results = JSON.parse(text); |
There was a problem hiding this comment.
Small issue here, results is expected to be an async iterator (for the for-await loop below). It's likely not warning here since the result of the parse is any and it may still appear to work, but that likely will run into a runtime error 🤔
JoviDeCroock
force-pushed
the
account-for-absent-content-type
branch
from
b3cfd44
to
9410b43
Compare
kitten
approved these changes
Nov 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As seen in #3429, some servers send back the response as
text/plainwhich can still be valid JSON.