fix(core): Allow path-only URLs to be used with GET requests #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a0015d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
reviewed
Mar 2, 2024
There was a problem hiding this comment.
Great work! I only have some nits here.
We indeed previously assumed that a full URL will be passed, but of course, this doesn't give a user the most options, so I appreciate the suggestion! The test is great too ❤️
I've left the nits mostly for code style / byte savings, so that's why they're nits
kitten
reviewed
Mar 2, 2024
kitten
approved these changes
Mar 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes query parameter handling to allow path-only URLs (i.e.
/api/graphql) passed tofetchto be used with GET requests. This was previously broken asURLwould throw aTypeError: Invalid URLas it only works with fully formed URLs.Extracting the unparsed query parameters is now done manually, so as to not depend on
URL. Important to note is that the current method will not handle URLs with fragments (i.e./api/graphql#fragment) in them, but it is easy to add if desired.