Fix cache-and-network/stale on client.reexecuteOperation queue #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to designate the first dispatch to empty the queue instead of starting to empty the queue after, which can lead the next reexecuteOperation call to empty the queue instead.
🦋 Changeset is good to goLatest commit: 7dce9f5 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Mar 25, 2020
kitten
force-pushed
the
fix/client-dispatching-queue
branch
from
45c451a
to
7dce9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #668
Summary
This fixes an edge case that was missed in #662.
The queue wasn't marked as being started by the first
client.dispatchOperation, which means that the queue is then emptied by the firstclient.rexecuteOperationcall instead. This doesn't cause any issues usually, but with thededupExchangewe'll accidentally deduplicate reissued operations, which are usually used to implement fetching forstaleresults orcache-and-networkoperations.Set of changes
client.dispatchOperationclient.exchange(private variable)