Revert me: Don't require clippy CI stage to succeed
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some
dylintstuff to our CI docker image in paritytech/scripts#382. The docker image can't be build currently though: https://gitlab.parity.io/parity/cargo-contract/-/jobs/1376793.This is due to an ICE in the nightly version of the Rust compiler (rust-lang/rust#93788). Since I need those
dylinttools now-ish, I would like to temporarily allow theclippystage to fail. We can revert this PR once the ICE is fixed.Let's not go into a discussion of setting a fixed toolchain for our CI here.