Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades binaryen to version 111.
Binaryen (and wasm-opt) now enables the
SignExt
andMutableGlobals
features by default, which are also enabled in the LLVM backend. In the future Binaryen will align its default feature selection with the LLVM backend.This is probably is ok for cargo-contract - I assume, but don't know, that the substrate wasm vm allows these two common features.
This also points to potential future optimizations by explicitly turning on more features that the substrate vm supports, but aren't being enabled in wasm-opt.
The changelog for 0.111.0.
I see that the cargo-contract current version is a beta. If a major release is impending, it might be prudent to delay merging this.