Rework fallible constructors #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
SkymanOne
reviewed
Nov 14, 2022
SkymanOne
reviewed
Nov 14, 2022
|
I am also getting clippy warning for constructors attribute: Currently debugging this |
* revert instantiating when error * display name + correct return typ when Self * fix dereferencing issue * UI test error variant + cleanup * cargo fmt * cargo fmt * fix another reference issue * fix spec contract test Co-authored-by: Andrew Jones <ascjones@gmail.com>
ascjones
changed the title
ascjones
commented
Nov 17, 2022
| @@ -0,0 +1,35 @@ | |||
| [package] | |||
| name = "constructors_return_value" | |||
There was a problem hiding this comment.
I've added this "example" into your integration tests folder @HCastano, because already all the CI scripts and waterfall tests deal with this special case folder. Perhaps we could introduce an integration-tests folder and have feature specific integration tests in there.
There was a problem hiding this comment.
Perhaps we could introduce an integration-tests folder and have feature specific integration tests in there.
Yep, I was thinking the same thing
HCastano
approved these changes
Nov 17, 2022
Comment on lines
+27
to
+33
| fn generate_metadata() -> InkProject { | ||
| extern "Rust" { | ||
| fn __ink_generate_metadata() -> InkProject; | ||
| } | ||
|
|
||
| unsafe { __ink_generate_metadata() } | ||
| } |
| unsafe { __ink_generate_metadata() } | ||
| } | ||
|
|
||
| fn main() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1460 and #1446. Closes #1483.
This PR:
Test with:
cargo test --manifest-path ./examples/lang-err-integration-tests/constructors-return-value/Cargo.toml --features e2e-tests