Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation errors events #1533

Merged
merged 6 commits into from
Dec 12, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Dec 11, 2022

  • Fixed a small compilation error
  • Applied fmt
  • Merged with master

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (aj/shared-events@bba0e88). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2cd3a0c differs from pull request most recent head 77993e9. Consider uploading reports for the commit 77993e9 to get more accurate results

@@                 Coverage Diff                 @@
##             aj/shared-events    #1533   +/-   ##
===================================================
  Coverage                    ?   71.62%           
===================================================
  Files                       ?      205           
  Lines                       ?     6295           
  Branches                    ?        0           
===================================================
  Hits                        ?     4509           
  Misses                      ?     1786           
  Partials                    ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HCastano
Copy link
Contributor

Do you have an example contract showing what the compilation error is? Can you also rebase this on master so that German's PR isn't included in the commit history

@xgreenx
Copy link
Collaborator Author

xgreenx commented Dec 11, 2022

I want to highlight that it is a PR to Andrew's #1243.

You can see the compilation error here.

@xgreenx xgreenx mentioned this pull request Dec 11, 2022
5 tasks
@ascjones ascjones merged commit c999880 into use-ink:aj/shared-events Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants