[ink_e2e] method to generate and fund unique accounts
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lets us grab what's in the output buffer after our call to `instantiate`, however we are unable to succesfully decode the `AccountId` from the success case.
I accidently introduced this not knowing that the generic `C` was for the return type
Is supposed to help give better error messages if somebody uses a wrong type with the builder
Co-authored-by: Andrew Jones <ascjones@gmail.com>
Fixes some inconsistent errors between Clippy and `rustc`
cmichi
reviewed
Jan 24, 2023
cmichi
reviewed
Jan 24, 2023
cmichi
approved these changes
Jan 24, 2023
Co-authored-by: Michael Müller <mich@elmueller.net>
|
I suggest to merge #1591 first, then we can merge this into |
Codecov Report
@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
- Coverage 64.84% 64.68% -0.16%
==========================================
Files 205 207 +2
Lines 6286 6417 +131
==========================================
+ Hits 4076 4151 +75
- Misses 2210 2266 +56
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Base automatically changed from
aj/get-lang-error-from-create-builder
to
master
January 24, 2023 19:24
ascjones
added a commit
that referenced
this pull request
Jan 25, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows individual tests to generate their own unique accounts to avoid the problem of race conditions between tests using the same account, causing failures in #1591.
Can consider integrating this into the environment somehow, but for now providing the method is a good start.
master. So this PR view shows commits and changes from those PRs.For the clean diff see the commit view 8321e6f