Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subxt, scale-* and sp-* dependencies #1795

Merged
merged 14 commits into from
Jun 23, 2023
Merged

Update subxt, scale-* and sp-* dependencies #1795

merged 14 commits into from
Jun 23, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jun 1, 2023

Compatible with https://github.com/paritytech/substrate-contracts-node/releases/tag/v0.27.0

Also updates to latest pallet-contract-primitives release, and fixes compilation errors with new EventRecord type parameter on the result types.

Note for now we are using () as the EventRecord type, so the events decoding itself will be skipped, and the dry-run events will not be used. This is because at the moment we don't have a top level Event type available to us for decoding. For that we would need to use the subxt macro again to get the generated Event type which would couple us tightly to a specific version of substrate-contracts-node. While the dry-run events would be useful, we will defer this work for a future PR.

@ascjones ascjones changed the title Update subxt, scale-* and substrate dependencies Update subxt, scale-* and sp-* dependencies Jun 1, 2023
@ascjones
Copy link
Collaborator Author

ascjones commented Jun 8, 2023

Depends on new substrate-contracts-node release paritytech/substrate-contracts-node#192

Blocked on updating substrate-contracts-node to polkadot-v0.9.43, which in fact contains the updated ContractResult<R, Balance, EventRecord> with the EventRecord parameter type.

@ascjones ascjones marked this pull request as draft June 8, 2023 13:27
@ascjones ascjones marked this pull request as ready for review June 22, 2023 10:45
ascjones added a commit to paritytech/substrate-contracts-node that referenced this pull request Jun 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #1795 (6305e04) into master (e0bff56) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
- Coverage   52.21%   52.13%   -0.09%     
==========================================
  Files         207      206       -1     
  Lines        6663     6660       -3     
==========================================
- Hits         3479     3472       -7     
- Misses       3184     3188       +4     
Impacted Files Coverage Δ
crates/e2e/src/xts.rs 0.00% <ø> (ø)
crates/e2e/src/node_proc.rs 72.88% <100.00%> (-0.46%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascjones ascjones merged commit 05e3a12 into master Jun 23, 2023
@ascjones ascjones deleted the aj/update-subxt branch June 23, 2023 10:43
ascjones added a commit that referenced this pull request Aug 23, 2023
ascjones added a commit that referenced this pull request Aug 23, 2023
…1884)

* Manual backport of #1883: Use `contract-build` `3.2.0`

* ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (#1850)

* Update ink-e2e to the latest substrate-contracts-node

* Apply rust-fmt

* Change logging, to be up-to-date with master branch

* Apply rustfmt-nightly

(cherry picked from commit 6d7810e)

* Remove --ws-port arg

* Update substrate deps

* Manual backports of #1795 and #1855 to update subxt

* Update subxt in example

* Backport: fix e2e test, account for contract initial free balance (#1777)

* Use latest CI image

* 🦖 fix spellcheck for new version, add words to dict (#1836)

* Fix call-runtime tests

* enable call-runtime tests

* ui tests

* `[ink_e2e]` update `Determinism` enum to match Substrate definition (#1781)

* `[ink_e2e]` update `Determinism` enum to match Substrate definition

* fmt

* Fix multi_contract_caller example for new deposit behaviour

* Reenable examples-test step

* Fix integration test

* Remove riscv +stable

* Fix riscv build

---------

Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
goastler pushed a commit to prosopo/ink_sr25519 that referenced this pull request Aug 31, 2023
…se-ink#1884)

* Manual backport of use-ink#1883: Use `contract-build` `3.2.0`

* ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (use-ink#1850)

* Update ink-e2e to the latest substrate-contracts-node

* Apply rust-fmt

* Change logging, to be up-to-date with master branch

* Apply rustfmt-nightly

(cherry picked from commit 6d7810e)

* Remove --ws-port arg

* Update substrate deps

* Manual backports of use-ink#1795 and use-ink#1855 to update subxt

* Update subxt in example

* Backport: fix e2e test, account for contract initial free balance (use-ink#1777)

* Use latest CI image

* 🦖 fix spellcheck for new version, add words to dict (use-ink#1836)

* Fix call-runtime tests

* enable call-runtime tests

* ui tests

* `[ink_e2e]` update `Determinism` enum to match Substrate definition (use-ink#1781)

* `[ink_e2e]` update `Determinism` enum to match Substrate definition

* fmt

* Fix multi_contract_caller example for new deposit behaviour

* Reenable examples-test step

* Fix integration test

* Remove riscv +stable

* Fix riscv build

---------

Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
goastler pushed a commit to prosopo/ink_sr25519 that referenced this pull request Aug 31, 2023
…se-ink#1884)

* Manual backport of use-ink#1883: Use `contract-build` `3.2.0`

* ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (use-ink#1850)

* Update ink-e2e to the latest substrate-contracts-node

* Apply rust-fmt

* Change logging, to be up-to-date with master branch

* Apply rustfmt-nightly

(cherry picked from commit 6d7810e)

* Remove --ws-port arg

* Update substrate deps

* Manual backports of use-ink#1795 and use-ink#1855 to update subxt

* Update subxt in example

* Backport: fix e2e test, account for contract initial free balance (use-ink#1777)

* Use latest CI image

* 🦖 fix spellcheck for new version, add words to dict (use-ink#1836)

* Fix call-runtime tests

* enable call-runtime tests

* ui tests

* `[ink_e2e]` update `Determinism` enum to match Substrate definition (use-ink#1781)

* `[ink_e2e]` update `Determinism` enum to match Substrate definition

* fmt

* Fix multi_contract_caller example for new deposit behaviour

* Reenable examples-test step

* Fix integration test

* Remove riscv +stable

* Fix riscv build

---------

Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
Aero524 pushed a commit to Aero524/constracts_node that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants