Linter: Update toolchain #2067
Merged
Linter: Update toolchain #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubnzv
commented
Jan 19, 2024
| @@ -224,8 +224,6 @@ impl<'a, 'tcx> AnalysisDomain<'tcx> for StrictBalanceEqualityAnalysis<'a, 'tcx> | |||
|
|
|||
| const NAME: &'static str = "strict_balance_equality"; | |||
|
|
|||
| type Direction = Forward; | |||
There was a problem hiding this comment.
The default Direction is Forward, see: rust-lang/rust#120130
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
=======================================
Coverage 53.60% 53.60%
=======================================
Files 224 224
Lines 7107 7107
Branches 3146 3146
=======================================
Hits 3810 3810
Misses 3297 3297 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri Jan 19 15:00:54 CET 2024 |
cmichi
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo-contractorpallet-contracts?Update the toolchain version and the uses of internal rustc APIs.
Description
It would be beneficial to compile both the linter and
cargo-contractusing the same toolchain version. This approach would prevent the need to build a second toolchain in the CI and on user's machine when compiling a contract.The necessity of this update because
subxt, a dependency ofcargo-contract, requires rustc version 1.74.0 or higher, thereforecargo-contractcannot be built with the toolchain used in the linter before this PR.Checklist before requesting a review
CHANGELOG.md