Release 5.0.0-rc.1
#2106
Release 5.0.0-rc.1
#2106
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
- Coverage 53.67% 53.63% -0.04%
==========================================
Files 223 224 +1
Lines 7041 7046 +5
Branches 3117 3118 +1
==========================================
Hits 3779 3779
- Misses 3262 3267 +5 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Feb 13 16:07:58 CET 2024 |
Cargo.lock
Outdated
| "ink_env 5.0.0-rc", | ||
| "ink_metadata 5.0.0-rc", |
There was a problem hiding this comment.
We should first release these two packages, then release a new contract-transcode, then update to that version. Also will need to release and update contract-build at the same time, though that has no ink deps itself.
We should probably add that to the release process.
| @@ -121,7 +121,7 @@ pub mod flipper { | |||
|
|
|||
| // when | |||
| let call_data = vec![ | |||
| Value::from_bytes(&contract.account_id), | |||
| Value::unnamed_variant("Id", [Value::from_bytes(contract.account_id)]), | |||
There was a problem hiding this comment.
I think it may have sense to understand why and when it has changed.
I also noticed that the drink client returns metadata in version V14. Shouldn't it be V15?
There was a problem hiding this comment.
This is the issue that we should resolve before the final release. For now, I'm just gonna push the release gracefully.
Added
non_fallible_apilint - #2004create_call_builderfor testing existing contracts - #2075call_v2cross-contract calls with additional limit parameters - #2077Changed
Mapping: Reflect all possible failure cases in comments ‒ #2079.callto.call_builder‒ #2078runtime_onlyattribute argument - #2083additional_contractsparameter #2098Fixed
StorageVectype by excluding thelen_cachedfield from its type info - #2052approve_forin the ERC-721 example - #2092transfer_token_fromnow ensures the token owner is correct - #2093