Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: fix bumping workflows #6

Merged
merged 1 commit into from
Dec 18, 2024
Merged

.github: fix bumping workflows #6

merged 1 commit into from
Dec 18, 2024

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 18, 2024

Important

Adjust GitHub workflows to update v1 and v2 tags separately, ensuring v1 remains backed by Blacksmith cache.

  • Workflows:
    • In bump-cache-version.yml, change tag update from v2 to v1 to keep v1 backed by Blacksmith cache.
    • Add new workflow bump-tag.yml to update v2 tag independently.
  • Notifications:
    • Update Slack notification in bump-cache-version.yml to reflect v1 tag update.
    • Add Slack notification in bump-tag.yml for v2 tag update.

This description was created by Ellipsis for b4a0a5a. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b4a0a5a in 16 seconds

More details
  • Looked at 68 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/bump-tag.yml:12
  • Draft comment:
    The comment here contradicts the PR description. The description mentions bumping v1, but this workflow bumps v2. Please ensure the comment and logic align with the intended change.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. .github/workflows/bump-tag.yml:25
  • Draft comment:
    The Slack notification message should reflect the correct tag being updated. If the logic is to update v2, the message is correct. If the logic changes to v1, update the message accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_ajxRWL8s5W4TbqCi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 708a029 into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants