Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add path params on newHttpRequest #2843

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jokj624
Copy link
Contributor

@jokj624 jokj624 commented Aug 15, 2024

Description

  • Fixed an issue where query params and path params were not being added correctly in the newHttpRequest() called from the new request modal.

Screen shots

only path params
bruno-path-params.mov
only query params
bruno-query-params.mov
query + path params
bruno-query-and-path.mov

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 4169bb7 into usebruno:main Aug 16, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @jokj624 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path Params are not recognized when creating a new request
3 participants