Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): rendering interact values #1583

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

saeta-eth
Copy link
Contributor

This PR addresses two issues:

  • The interact section occasionally displayed (no result) despite having a valid value.
  • At times, it displayed [Object Object] instead of the expected content.

Test link: https://usecannon.com/packages/foil/0.38/11155111-main/interact/foil/Foil/0x4a61f58c535fd18e3bb1f14bbf4b362f78dfa8cf#selector-0xa3d74f06

Before:
Screenshot 2024-12-10 at 2 21 30 AM
After:
Screenshot 2024-12-10 at 2 22 26 AM

@saeta-eth saeta-eth added the bug Something isn't working label Dec 10, 2024
@saeta-eth saeta-eth self-assigned this Dec 10, 2024
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: abf0fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjlescano mjlescano merged commit 75b3482 into dev Dec 10, 2024
6 of 9 checks passed
@mjlescano mjlescano deleted the fix/interact-values-rendering branch December 10, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants