Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more supported cron values #345

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 30, 2024

The old crontab generator just passed through values for day and month:

elif [ "$index" = "3" ]; then
MONTHS=$piece
# Day of Week
elif [ "$index" = "4" ]; then
DAY_WEEK="$piece"
while the new cron validates them.

Some values were not included in the validations, this PR addresses those.

http://man.he.net/man5/crontab

       # Example of job definition:
       # .---------------- minute (0 - 59)
       # |  .------------- hour (0 - 23)
       # |  |  .---------- day of month (1 - 31)
       # |  |  |  .------- month (1 - 12) OR jan,feb,mar,apr ...
       # |  |  |  |  .---- day of week (0 - 6) (Sunday=0 or 7) OR sun,mon,tue,wed,thu,fri,sat
       # |  |  |  |  |

@shreddedbacon shreddedbacon force-pushed the supported-cron-values branch from c26e7e1 to f7c0ad8 Compare July 30, 2024 11:06
@shreddedbacon shreddedbacon marked this pull request as ready for review July 30, 2024 21:50
@shreddedbacon shreddedbacon merged commit 367f68d into main Jul 30, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the supported-cron-values branch July 30, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant