chore: remove slow capabilities check #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
changed the title
shreddedbacon
force-pushed
the
remove-capabilities-check
branch
from
68ef5a2 to
a1eb122
Compare
shreddedbacon
force-pushed
the
remove-capabilities-check
branch
from
a1eb122 to
27af279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the check against the kubernetes API to determine all available APIs. This check can be slow sometimes which can lead to builds being slow in the phase where it collects this information.
Rather than query for everything, target the specific APIs and check for an error if they exist or not to determine the capability exists or not.