chore: address more linting issues (#394)

cmd/config.go

@@ -215,7 +215,7 @@ var configDeleteCmd = &cobra.Command{
 
 		if lagoonConfig.Lagoon == "" {
 			fmt.Println("Missing arguments: Lagoon name is not defined")
-			cmd.Help()
+			_ = cmd.Help()
 			os.Exit(1)
 		}
 		if yesNo(fmt.Sprintf("You are attempting to delete config for lagoon '%s', are you sure?", lagoonConfig.Lagoon)) {

cmd/root.go

@@ -106,7 +106,7 @@ var rootCmd = &cobra.Command{
 			displayVersionInfo()
 			return
 		}
-		cmd.Help()
+		_ = cmd.Help()
 		os.Exit(1)
 	},
 }

cmd/ssh.go

@@ -76,7 +76,12 @@ var sshEnvCmd = &cobra.Command{
 				HostKeyCallback:   hkcb,
 				HostKeyAlgorithms: hkalgo,
 			}
-			defer closeSSHAgent()
+			defer func() {
+				err = closeSSHAgent()
+				if err != nil {
+					fmt.Fprintf(os.Stderr, "error closing ssh agent:%v\n", err)
+				}
+			}()
 			if sshCommand != "" {
 				err = lagoonssh.RunSSHCommand(sshConfig, sshService, sshContainer, sshCommand, config)
 			} else {

cmd/users.go

@@ -311,7 +311,6 @@ var updateUserCmd = &cobra.Command{
 			return err
 		}
 		if firstName == "" && lastName == "" && emailAddress == "" {
-			cmd.Help()
 			output.RenderError("Missing arguments: Nothing to update, please provide a field to update", outputOptions)
 			return nil
 		}

cmd/web.go

@@ -17,7 +17,7 @@ var webCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		if cmdProjectName == "" {
 			fmt.Println("Missing arguments: Project name is not defined")
-			cmd.Help()
+			_ = cmd.Help()
 			os.Exit(1)
 		}
 

pkg/lagoon/ssh/main.go

@@ -43,13 +43,13 @@ func LogStream(config *ssh.ClientConfig, host, port string, argv []string) error
 func InteractiveSSH(lagoon map[string]string, sshService string, sshContainer string, config *ssh.ClientConfig) error {
 	client, err := ssh.Dial("tcp", lagoon["hostname"]+":"+lagoon["port"], config)
 	if err != nil {
-		return fmt.Errorf("Failed to dial: " + err.Error() + "\nCheck that the project or environment you are trying to connect to exists")
+		return fmt.Errorf("failed to dial: %s\nCheck that the project or environment you are trying to connect to exists", err.Error())
 	}
 
 	// start the session
 	session, err := client.NewSession()
 	if err != nil {
-		return fmt.Errorf("Failed to create session: " + err.Error())
+		return fmt.Errorf("failed to create session: %s", err.Error())
 	}
 	defer session.Close()
 	session.Stdout = os.Stdout