Added FactsUI and ProblemsUi to get project output #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
requested changes
Dec 1, 2022
There was a problem hiding this comment.
All good, just one step missing which I will need to make note of in our contributing docs is that any changes to x.graphql files requires a make gen to be run, otherwise the auto generated code doesn't get updated.
Once you run make gen and push up the corrected auto generated code, this should be ready for 🚀
|
closes #252 |
shreddedbacon
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The PR #249 introduced the ability to directly set the factsUi and problemsUi fields for a project.
Added factsUi and problems Ui to lagoon-cli/pkg/lagoon/projects/main.go and internal/lagoon/client/_lgraphql
Changelog Entry