Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add channel to slack and rocketchat notifications #279

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: add channel to slack and rocketchat notifications #279

merged 1 commit into from
Jun 27, 2023

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Fixes add slack and rocketchat to pass the channel value properly.

Changelog Entry

Closing issues

closes #278

polinashtanko
polinashtanko approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@polinashtanko polinashtanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working

@shreddedbacon shreddedbacon merged commit 6dd99a6 into main Jun 27, 2023
@shreddedbacon shreddedbacon deleted the notifications-fix branch June 27, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polinashtanko polinashtanko polinashtanko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lagoon add notification slack errors out
2 participants
@shreddedbacon @polinashtanko