Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Organizations support #292

Merged
merged 24 commits into from
Dec 5, 2023
Merged

Feature: Organizations support #292

merged 24 commits into from
Dec 5, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Sep 28, 2023

Provides basic CRUD & quality of life functionality.

Requires uselagoon/machinery#24

cmd/list.go Outdated Show resolved Hide resolved
@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 20, 2023 05:45
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of things to fix up. I'll have another look through once these get fixed up

cmd/shared.go Outdated Show resolved Hide resolved
cmd/organization.go Outdated Show resolved Hide resolved
cmd/organization.go Outdated Show resolved Hide resolved
cmd/organization.go Outdated Show resolved Hide resolved
cmd/organization.go Outdated Show resolved Hide resolved
cmd/get.go Outdated Show resolved Hide resolved
cmd/get.go Outdated Show resolved Hide resolved
@CGoodwin90
Copy link
Contributor Author

First round of things to fix up. I'll have another look through once these get fixed up

All updated now

cmd/organization.go Outdated Show resolved Hide resolved
@shreddedbacon shreddedbacon changed the title WIP: Organizations support Feature: Organizations support Nov 21, 2023
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot here, great work! I think for now this is great.

I have had a run through and everything seems to be working fine. Although I am finding the command flow a little bit clunky, but for now it will do.

Since the CLI hasn't reached 1.0.0 yet, we have some wiggle on structure of commands.

@shreddedbacon shreddedbacon merged commit 472d8ce into main Dec 5, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the feature/organizations branch December 5, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants