-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixes & refactors user-sshkey
commands
#303
Conversation
Also need to remove the old functions for these |
Removed |
Yep, if you can make it work :) |
I've merged the machinery pullrequest, but I'm going to review other machinery PRs first to determine any merge conflicts etc, and once that is all done we can tag a machinery release and update all the CLI PRs to use that new tag once it is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run make docs
and push up the changes to the documentation please :)
Otherwise this is good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Checklist
Updates
get user-sshkeys
to include the key id & refactored to use Machinery.Updates
delete user-sshkey
to use--id
flag instead of--name
& refactored to use Machinery.Requires uselagoon/machinery#28
closes #302