Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes & refactors user-sshkey commands #303

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Nov 16, 2023

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Updates get user-sshkeys to include the key id & refactored to use Machinery.
Updates delete user-sshkey to use --id flag instead of --name & refactored to use Machinery.

Requires uselagoon/machinery#28

closes #302

@shreddedbacon
Copy link
Member

Also need to remove the old functions for these

@CGoodwin90
Copy link
Contributor Author

Also need to remove the old functions for these

Removed DeleteSSHKey, ListUserSSHKeys is still being used by another cmd getAllUserKeys. Worth refactoring that too?

@shreddedbacon
Copy link
Member

Removed DeleteSSHKey, ListUserSSHKeys is still being used by another cmd getAllUserKeys. Worth refactoring that too?

Yep, if you can make it work :)

@CGoodwin90 CGoodwin90 marked this pull request as ready for review November 21, 2023 05:22
@shreddedbacon
Copy link
Member

I've merged the machinery pullrequest, but I'm going to review other machinery PRs first to determine any merge conflicts etc, and once that is all done we can tag a machinery release and update all the CLI PRs to use that new tag once it is released.

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run make docs and push up the changes to the documentation please :)

Otherwise this is good to go

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shreddedbacon shreddedbacon merged commit eeb83b5 into main Dec 5, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the fix-user-sshkey branch December 5, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix list user-sshkeys and change delete user-sshkey
2 participants