Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: commands to use machinery and clean up unused functions #321

Merged
merged 39 commits into from
Jun 19, 2024

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Mar 5, 2024

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This PR introduces some command reorganization, refactors most commands to be in-line with more recent additions & cleans up the legacy functions.

Changes:

  • Refactors most commands still using the legacy client to interact with the api to now utilize machinery
  • Adds helper functions for error handling and argument validation
  • Fixes minor bugs - incorrect alias', invalid return data etc
  • Removes unused legacy functions

Note: Some legacy functions remain as they are being used by functionality outside of this PR (e.g. Importer), which will be updated in a seperate PR.

@CGoodwin90 CGoodwin90 changed the title WIP: Updates various commands to utilize machinery + refactor & cleanup Refactor: Refactors most commands to utilize machinery & cleans up unused legacy functions Apr 24, 2024
@CGoodwin90 CGoodwin90 marked this pull request as ready for review May 1, 2024 07:21
@shreddedbacon shreddedbacon marked this pull request as draft May 13, 2024 02:03
@shreddedbacon
Copy link
Member

@CGoodwin90 are you still working on this? Would be cool to look at merging before it gets crazier

@CGoodwin90
Copy link
Contributor Author

@CGoodwin90 are you still working on this? Would be cool to look at merging before it gets crazier

Nah it's good to go, was just waiting for #332 to go in first. I'll rebase and mark ready.

@CGoodwin90 CGoodwin90 marked this pull request as ready for review June 11, 2024 04:09
@shreddedbacon shreddedbacon force-pushed the update-cmds-use-machinery branch from 0ce8f22 to 050a394 Compare June 16, 2024 23:41
@shreddedbacon shreddedbacon force-pushed the update-cmds-use-machinery branch from 050a394 to 8eab507 Compare June 17, 2024 00:04
@shreddedbacon shreddedbacon self-requested a review June 19, 2024 23:38
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good now.

Will need to ensure the release notes contain a notification about the breaking changes to some flags

@shreddedbacon shreddedbacon merged commit adbc9a3 into main Jun 19, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the update-cmds-use-machinery branch June 19, 2024 23:41
@shreddedbacon shreddedbacon changed the title Refactor: Refactors most commands to utilize machinery & cleans up unused legacy functions refactor: commands to use machinery and clean up unused functions Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants