-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: commands to use machinery and clean up unused functions #321
Conversation
machinery
+ refactor & cleanupmachinery
& cleans up unused legacy functions
@CGoodwin90 are you still working on this? Would be cool to look at merging before it gets crazier |
Nah it's good to go, was just waiting for #332 to go in first. I'll rebase and mark ready. |
…and return err in missed err capture
0ce8f22
to
050a394
Compare
050a394
to
8eab507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good now.
Will need to ensure the release notes contain a notification about the breaking changes to some flags
machinery
& cleans up unused legacy functions
Checklist
This PR introduces some command reorganization, refactors most commands to be in-line with more recent additions & cleans up the legacy functions.
Changes:
machinery
Note: Some legacy functions remain as they are being used by functionality outside of this PR (e.g. Importer), which will be updated in a seperate PR.