Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds build variables to deployBranchCmd #325

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Mar 17, 2024

This POC introduces the ability to pass build variables to a deployment in a way that mirrors the GraphQL API.

It adds the ability to add command line arguments of the form --buildvar KEY1=VAL1 [--buildvar KEY2=VAL2] etc.

These will then be passed along to the graphQL deploy call as build variables.

This functionality is particularly important when deploying a new environment that requires build variables, which cannot be set since the environment doesn't yet exist.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

@bomoko bomoko requested a review from shreddedbacon March 17, 2024 23:26
cmd/helpers.go Outdated Show resolved Hide resolved
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. The split after 2 would be good to address though before merge in case someone adds a base64 encoded variable payload that contains potentially additional = signs.

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. SplitN 👨‍🍳

@shreddedbacon shreddedbacon merged commit a2838f8 into main Mar 19, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the feature/pass_build_vars_to_deploy branch March 19, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants