refactor: actually handle passphrase protected keys #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
protected-keys
branch
from
ad1309a to
4183eaf
Compare
bomoko
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Just fixes the logic around the existing passphrase protected SSH key implementation in the CLI. It will now actually prompt if it detects a passphrase protected key.
This does not for work keys protected by yubikeys or the like, they will need to be added to ssh-agent, which is the recommended path generally. This support is purely for users that may use multiple keys, to access a single Lagoon that want to ensure they are using the right key to access a specific account.
Changelog Entry