Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use stringarray instead of stringslice for buildvars #334

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: use stringarray instead of stringslice for buildvars #334

merged 1 commit into from
Apr 8, 2024

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The StringSlice type has some checks that splits with comma separated values, StringArray doesn't appear to do the same thing. This updates the commands to use the StringArray type.

Changelog Entry

Closing issues

closes #333

@shreddedbacon shreddedbacon requested a review from bomoko April 7, 2024 21:42
@shreddedbacon shreddedbacon marked this pull request as ready for review April 7, 2024 21:42
@bomoko
Copy link
Contributor

bomoko commented Apr 8, 2024

Tested locally, looks good.

@shreddedbacon shreddedbacon merged commit fba77eb into main Apr 8, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the buildvar-fix branch April 8, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The buildvar flag doesn't support values with commas
2 participants
@shreddedbacon @bomoko