refactor: add versioned requests for machinery based requests #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
versioned-machinery-requests
branch
2 times, most recently
from
d817aa7 to
ae70239
Compare
shreddedbacon
force-pushed
the
versioned-machinery-requests
branch
from
ae70239 to
683642b
Compare
bomoko
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Allows for versioned requests using machinery so that updates to schemas can be handled better.
Additionally, the lagoon api version check is performed whenever a token is refreshed, this gives the benefit of always being able to know the version of the api that is being targeted without the user having to specifically call the check. It can add a delay to token refreshes though, but will happen in the background like a normal token refresh anyway.
Eventually this could use the
.well-known/appspecific/sh.lagoon.discovery.jsonendpoint when discovery is introduced properly, which would be faster than using the API version call.