move security.txt block in nginx-drupal #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhamlin
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
After using the PR image (testlagoon/nginx-drupal:pr-654) locally with a Drupal 9.5 site, I can confirm it works as expected. The main issues encountered were with the Drupal module for some reason requiring a permission to 'view' the security.txt file, even after making it. After solving this, all works as expected (both the security.txt file and the security.txt.sig).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #500, support for the drupal security.txt module was added to nginx-drupal. In practice though, a higher level match procluded access to .txt files outside of the sites/*/files folder.
This PR moves the security.txt block ahead of that block to ensure it processes ahead of it, and additionally removes the restriction on the .well-known folder being in the webroot - which enables the UI file download for signing in multilingual sites.
