Correctly escape complex shell commands #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a shellescape package which implements algorithm 1 described in https://stackoverflow.com/a/20053121. This algorithms is essentially: wrap in single quotes, escape any single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, complex shell commands were not escaped correctly which led to ssh commands like:
ssh example-master@ssh.test.example.com /bin/sh -c '( echo foo; echo bar; echo baz ) | tail -n2'Returning an error like:
This change implements shell escaping using the algorithm described in ponit 1. of this stack overflow answer to correctly handle complex ssh commands such as the one above.