Merge pull request #2917 from uselagoon/routerpattern-check-v2

fix: routerpattern can be null, so check if undefined
uselagoon · Nov 8, 2021 · 59a2387 · 59a2387
2 parents 52482ad + 513b2de
commit 59a2387
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/node-packages/commons/src/tasks.ts b/node-packages/commons/src/tasks.ts
@@ -402,7 +402,11 @@ export const getControllerBuildData = async function(deployData: any) {
 
   var openshiftProject = openshiftProjectPattern ? openshiftProjectPattern.replace('${environment}',environmentName).replace('${project}', projectName) : `${projectName}-${environmentName}`
 
-  var routerPattern = deployTarget.openshift.routerPattern || lagoonProjectData.openshift.routerPattern
+  var routerPattern = lagoonProjectData.openshift.routerPattern
+  if (typeof deployTarget.openshift.routerPattern !== 'undefined') {
+    // null is a valid value for routerPatterns...
+    routerPattern = deployTarget.openshift.routerPattern
+  }
   var deployTargetName = deployTarget.openshift.name
   var monitoringConfig: any = {};
   try {