Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Typed Facts #2484

Closed
wants to merge 5 commits into from
Closed

Adds Typed Facts #2484

wants to merge 5 commits into from

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Jan 26, 2021

This PR addresses feature request #2483

It introduces a very simple typing system, one which could be easily expanded in the future to (as a first step) introduce, for instance, semver as a "type" (which would make searching environments based on ranges a lot easier than simply on text)

This also introduces a small change to the fact listing page, demonstrated below

image

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Closing issues

closes #2483

@bomoko bomoko requested a review from timclifford January 26, 2021 01:49
@bomoko bomoko marked this pull request as ready for review January 28, 2021 18:38
@tobybellwood
Copy link
Member

let's get this rebased against main, and roll it into the other facts tasks underway?

@bomoko
Copy link
Contributor Author

bomoko commented Mar 31, 2022

This is incorporated into Lagoon 2 - closing.

@bomoko bomoko closed this Mar 31, 2022
@bomoko bomoko deleted the feature/typed_facts branch March 31, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants